Skip to content

Add PR template#387

Merged
camilamaia merged 1 commit intomasterfrom
PRTemplate
Jun 3, 2021
Merged

Add PR template#387
camilamaia merged 1 commit intomasterfrom
PRTemplate

Conversation

@Pradhvan
Copy link
Copy Markdown
Member

@Pradhvan Pradhvan commented Jun 1, 2021 •
edited
Loading

  • Added PR template with a checklist for the author.
  • Added instructions in the checklists that points to the wiki.
  • Added a heading to reference PR template to related issue it closes.

Closes #383

@Pradhvan Pradhvan requested review from a team as code owners June 1, 2021 05:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 1, 2021

@Pradhvan your pull request is missing a changelog!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #387 (4134b51) into master (7f80588) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          22       22           
  Lines         662      662           
=======================================
  Hits          634      634           
  Misses         28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f80588...4134b51. Read the comment docs.

camilamaia
camilamaia reviewed Jun 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Pradhvan! I've added some suggestions, let me know what do you think :)

Comment thread .github/PULL_REQUEST_TEMPLATE/pull_request_template.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE/pull_request_template.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE/pull_request_template.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE/pull_request_template.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
Comment thread .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
@camilamaia camilamaia mentioned this pull request Jun 2, 2021
Closed
6 tasks
@Pradhvan
Copy link
Copy Markdown
Member Author

Pradhvan commented Jun 3, 2021

Thanks @Pradhvan! I've added some suggestions, let me know what do you think :)

Changes look good to me. I will update the PR. 👍🏾

@Pradhvan
Add PR template
70e5060 
* Added PR template with a checklist for the author.
* Added instructions in the checklists that points to the wiki.
* Added a heading to reference PR template to related issue it closes.

Closes: #383
@Pradhvan Pradhvan requested a review from camilamaia June 3, 2021 05:32
camilamaia
camilamaia approved these changes Jun 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

@camilamaia camilamaia merged commit ce9e036 into master Jun 3, 2021
@camilamaia camilamaia deleted the PRTemplate branch June 3, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamaia camilamaia camilamaia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a GitHub PR Template

3 participants

@Pradhvan @codecov-commenter @camilamaia