Skip to content

Add issue template#385

Merged
camilamaia merged 1 commit intomasterfrom
IssueTemplate
Jun 2, 2021
Merged

Add issue template#385
camilamaia merged 1 commit intomasterfrom
IssueTemplate

Conversation

@Pradhvan
Copy link
Copy Markdown
Member

@Pradhvan Pradhvan commented May 29, 2021

  • Added three templates for bug_report, feature_request and how to
    question.

Closes #382

@Pradhvan Pradhvan requested review from a team as code owners May 29, 2021 12:36
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 29, 2021

@Pradhvan your pull request is missing a changelog!

camilamaia
camilamaia reviewed May 31, 2021
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/how_to_question.md Outdated
camilamaia
camilamaia reviewed May 31, 2021
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/bug_report.md
@camilamaia
Copy link
Copy Markdown
Member

camilamaia commented May 31, 2021

Hey @Pradhvan, since you have been helping us a LOT with ScanAPI, we've promoted you to a Maintainer 🎉 Now you have the maintain permission for our repos! We still don't have official docs explaining more about this role, but we definitely should soon (And probably also some other docs to explain how to apply for roles). We just wanted to promote you and we thought we should not postpone it

But please keep in mind, as we said in our CONTRIBUTING guide:

Do not ever feel bad for not contributing to open source.

This is our way to say thanks for all the effort you have ALREADY done for ScanAPI 😻.

Thank you again!! 🎉

@Pradhvan
Copy link
Copy Markdown
Member Author

Pradhvan commented Jun 1, 2021

We just wanted to promote you and we thought we should not postpone it

@camilamaia thank you so much. ❤️

Excited to be part of the team. 🙌🏾

@Pradhvan
Copy link
Copy Markdown
Member Author

Pradhvan commented Jun 1, 2021

@camilamaia updated the discord server link. Do I need to add a changelog too?

Besides that, I think it's good to go 🚀 Let's merge this. :octocat:

Pradhvan
Pradhvan commented Jun 1, 2021
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/how_to_question.md Outdated
@Pradhvan
Add issue template
5a94701 
* Added three templates for bug_report, feature_request and how to
question.

Closes #382
@camilamaia
Copy link
Copy Markdown
Member

camilamaia commented Jun 2, 2021

@Pradhvan Perfect, let me merge it! Thanks for the hard work 💪

No need for a changelog entry, since this is only internal changes, it is not a change that effect users of ScanAPI.
https://github.com/scanapi/scanapi/wiki/Changelog#what-warrants-a-changelog-entry

@camilamaia camilamaia merged commit e059845 into master Jun 2, 2021
@camilamaia camilamaia deleted the IssueTemplate branch June 2, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamaia camilamaia camilamaia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a GitHub issue Template

2 participants

@Pradhvan @camilamaia