Skip to content

run black from makefile#347

Merged
camilamaia merged 3 commits intomasterfrom
marcuxyz/run-lint-from-makefile
Dec 16, 2020
Merged

run black from makefile#347
camilamaia merged 3 commits intomasterfrom
marcuxyz/run-lint-from-makefile

Conversation

@marcuxyz
Copy link
Copy Markdown
Member

@marcuxyz marcuxyz commented Dec 11, 2020

Closes #351

@marcuxyz marcuxyz requested review from a team as code owners December 11, 2020 21:20
@github-actions
Copy link
Copy Markdown

@marcuxyz your pull request is missing a changelog!

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 11, 2020

Codecov Report

Merging #347 (6e88e48) into master (b29db93) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files          19       19           
  Lines         635      635           
=======================================
  Hits          609      609           
  Misses         26       26           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29db93...6e88e48. Read the comment docs.

@github-actions
Copy link
Copy Markdown

@camilamaia your pull request is missing a changelog!

@camilamaia camilamaia force-pushed the marcuxyz/run-lint-from-makefile branch 14 times, most recently from 0137afc to 7029bf2 Compare December 11, 2020 22:45
@camilamaia
Copy link
Copy Markdown
Member

@rvmoura96 we had to downgrade the black version back, sorry. We are trying to have the same version of lints for pre-commit, make format and github action, because the three needs to check in the same way. We tried to use the version you upgraded for all three, but this would need us to upgrade the python version in the project. This would be a major change and probably a major release, which is not planned for now. Sorry for the confusion!

@camilamaia camilamaia merged commit dc8d859 into master Dec 16, 2020
@camilamaia camilamaia deleted the marcuxyz/run-lint-from-makefile branch December 16, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Makefile, pre-commit and github action lints are not compatible

3 participants