Skip to content

Removed unused imports#294

Merged
camilamaia merged 4 commits intoscanapi:masterfrom
JRubics:#293
Oct 5, 2020
Merged

Removed unused imports#294
camilamaia merged 4 commits intoscanapi:masterfrom
JRubics:#293

Conversation

@JRubics
Copy link
Copy Markdown
Member

@JRubics JRubics commented Oct 3, 2020 •
edited
Loading

closes #293

@JRubics JRubics requested review from a team as code owners October 3, 2020 20:19
@JRubics JRubics changed the title #293 Removed unused imports Oct 3, 2020
@github-actions github-actions bot added the First Contribution First contribution to the project. label Oct 3, 2020
github-actions[bot]
github-actions bot reviewed Oct 3, 2020
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supporting ScanAPI, and congratulations on your first contribution! A project committer will shortly review your contribution.

In the mean time, if you haven't had a chance please skim over the First Pull Request Guide which all pull requests must adhere to.

We hope to see you around!

@camilamaia camilamaia merged commit 9cef3b3 into scanapi:master Oct 5, 2020
@camilamaia
Copy link
Copy Markdown
Member

camilamaia commented Oct 5, 2020

@JRubics thank you very much for the PR! Glad to see you here at ScanAPI! poetry-publish help us a lot in this project.

Also, I am going to send you an invite to join the ScanAPI org on GitHub 🚀 We invite everyone that has contributed with a merged PR in any of our repos. Here you can check our Community Continuity Guidelines so you can understand better how it works.

And once again, thank you! 🙇‍♀️

@JRubics JRubics deleted the #293 branch October 5, 2020 21:27
@JRubics
Copy link
Copy Markdown
Member Author

JRubics commented Oct 5, 2020

@camilamaia I am so happy to have a chance to help you :) This is the first community project that I contributed to, so I am really thankful for the trust you gave me by merging this pull request and using poetry-publish. 😄
I look forward to future contributions! I already have some ideas and found some issues I think I can contribute to! 😄

@camilamaia camilamaia mentioned this pull request Oct 6, 2020
Merged
@camilamaia
Copy link
Copy Markdown
Member

camilamaia commented Oct 8, 2020

@JRubics Wow, that is super cool! Glad to be part of this. So welcome to the open source world and of course, welcome to ScanAPI! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@camilamaia camilamaia camilamaia approved these changes

Assignees

No one assigned

Labels

First Contribution First contribution to the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unused imports

2 participants

@JRubics @camilamaia