Skip to content

Set no body as None instead of {}#280

Merged
camilamaia merged 1 commit intomasterfrom
262
Sep 29, 2020
Merged

Set no body as None instead of {}#280
camilamaia merged 1 commit intomasterfrom
262

Conversation

@camilamaia
Copy link
Copy Markdown
Member

On requests that have no body, ScanAPI is sending body as {} and Content-Length equals 2. The body should be None and the Content-Length should be 0.

Before

image

After

image

Closes #262

@camilamaia camilamaia requested review from a team as code owners September 27, 2020 23:02
@camilamaia camilamaia self-assigned this Sep 27, 2020
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #280 into master will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   93.81%   93.97%   +0.16%     
==========================================
  Files          19       19              
  Lines         598      598              
==========================================
+ Hits          561      562       +1     
+ Misses         37       36       -1     
Impacted Files Coverage Δ
scanapi/tree/request_node.py 98.38% <100.00%> (ø)
scanapi/evaluators/spec_evaluator.py 72.72% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd8139...279f52b. Read the comment docs.

Copy link
Copy Markdown
Contributor

@gillianomenezes gillianomenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@camilamaia camilamaia merged commit 4f98beb into master Sep 29, 2020
@camilamaia camilamaia deleted the 262 branch September 29, 2020 16:44
@camilamaia camilamaia mentioned this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GET requests are sending body as {} and Content-Length equals 2

3 participants