feat: Add local/global configuration support#254
Conversation
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 93.48% 93.49% +0.01%
==========================================
Files 19 19
Lines 583 584 +1
==========================================
+ Hits 545 546 +1
Misses 38 38
Continue to review full report at Codecov.
|
867a13a to
e4aa2e8
Compare
973ac55 to
aba4a4a
Compare
|
@supakeen hey, I added the missing tests! Would you mind to review it? Thank you very much!! |
| extension = os.path.splitext(file_path)[-1] | ||
|
|
||
| if extension not in (".yaml", ".yml", ".json"): | ||
| raise FileFormatNotSupportedError(extension, file_path) |
There was a problem hiding this comment.
Hi, @camilamaia! Good work on this PR 🚀 I have just a little question... How is the FileFormatNotSupportedError handled now?
There was a problem hiding this comment.
@gillianomenezes we are simply not checking the extension anymore... if pyaml cant convert it, then we will have an exception. Maybe it would be nice to check if this is handled properly.
There was a problem hiding this comment.
I've updated it with the suggestion :)
gillianomenezes
left a comment
There was a problem hiding this comment.
Looks good to me :)
fd98978 to
5cb603f
Compare
5cb603f to
746670d
Compare
Initial support for a different configuration filename and global configuration.
Created on top of: #225
closes #203
closes #131