Skip to content

Change command "scanapi <spec_file>" to "scanapi run <spec_file>"#247

Merged
camilamaia merged 9 commits intomasterfrom
change_main_command_to_run
Aug 3, 2020
Merged

Change command "scanapi <spec_file>" to "scanapi run <spec_file>"#247
camilamaia merged 9 commits intomasterfrom
change_main_command_to_run

Conversation

@abreumatheus
Copy link
Copy Markdown
Member

@abreumatheus abreumatheus commented Aug 1, 2020

Closes: [#226 ]

Changed

  • [BREAKING] - Changed command scanapi <spec_file> to scanapi run <spec_file>.

@abreumatheus abreumatheus requested review from a team as code owners August 1, 2020 23:32
@abreumatheus
Copy link
Copy Markdown
Member Author

abreumatheus commented Aug 1, 2020

Obs: It's failing on circleci: cangelog-lint but it doesn't tell me why, so i don't know how to fix it hahaha.

Pradhvan
Pradhvan reviewed Aug 2, 2020
View reviewed changes
Comment thread CHANGELOG.md Outdated
- Renamed `api.(yaml|json)` to `scanapi.yaml` [#222](https://github.com/scanapi/scanapi/issues/20://github.com/scanapi/scanapi/pull/222)
- Remove top-level `api` key in `scanapi.yaml`. [#231](https://github.com/scanapi/scanapi/pull/231)
- Renamed `project-name`, `hide-request` and `hide-response` to use underscore. [#228](https://github.com/scanapi/scanapi/issues/228)
- Changed command `scanapi <spec_file>` to `scanapi run <spec_file>`. [#247](https://github.com/scanapi/scanapi/pull/247)
Copy link
Copy Markdown
Member

@Pradhvan Pradhvan Aug 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abreumatheus just a wild guess here can you try

- Renamed change command "scanapi <spec_file>" to "scanapi run <spec_file>" [#247](https://github.com/scanapi/scanapi/pull/247)

Copy link
Copy Markdown
Member

@Pradhvan Pradhvan Aug 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that the stack trace of circleci dosen't give out any error message.

Copy link
Copy Markdown
Member

@barbosa barbosa Aug 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird 🤔. Diff outputs the same values.

Copy link
Copy Markdown
Member Author

@abreumatheus abreumatheus Aug 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pradhvan @barbosa Changed it, still failing :/

Copy link
Copy Markdown
Member

@barbosa barbosa Aug 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abreumatheus Now you got a different error. See:

-- Changed command "scanapi <spec_file>" to "scanapi run <spec_file>" [#247](https://github.com/scanapi/scanapi/pull/247) 
+- Changed command "scanapi " to "scanapi run " [#247](https://github.com/scanapi/scanapi/pull/247)

Apparently the tool is cutting out everything in between < >

Copy link
Copy Markdown
Member Author

@abreumatheus abreumatheus Aug 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barbosa Yeah, it wasn't it. Apparently Circle CI just hates me 🤣
Edit: I'm installing the linter used by Circle CI, will use it on the file and see if it corrects any invisible errors.

Copy link
Copy Markdown
Member

@Pradhvan Pradhvan Aug 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abreumatheus was it just the empty space in the end that was causing this issue ?

Copy link
Copy Markdown
Member Author

@abreumatheus abreumatheus Aug 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abreumatheus was it just the empty space in the end that was causing this issue ?

Honestly, i dont even know, just ran the linter locally and saved the output to a new file.

Copy link
Copy Markdown
Member

@Pradhvan Pradhvan Aug 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay. I saw the diff in the end and the only thing I could make out of it was that space xp

Copy link
Copy Markdown
Member

@camilamaia camilamaia Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, this was a nice team effort, what a battle 😂

👏👏👏

@abreumatheus
Copy link
Copy Markdown
Member Author

abreumatheus commented Aug 2, 2020

@barbosa @Pradhvan Fixed it! Ready to merge!

@barbosa barbosa requested review from Pradhvan and camilamaia August 2, 2020 17:30
camilamaia
camilamaia approved these changes Aug 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

@camilamaia camilamaia merged commit 725ab68 into master Aug 3, 2020
@camilamaia camilamaia deleted the change_main_command_to_run branch August 3, 2020 17:59
@Pradhvan
Copy link
Copy Markdown
Member

Pradhvan commented Aug 3, 2020

@camilamaia just a suggestion once the PR is ready to merge we can ask the PR creator to squash all the commits into one commit. That would help us in a cleaner git history too.

@camilamaia
Copy link
Copy Markdown
Member

camilamaia commented Aug 3, 2020

@Pradhvan great suggestion, I squashed and merged it: 725ab68

I set this as the default option for merging now for the repo

@camilamaia camilamaia mentioned this pull request Aug 3, 2020
Closed
@Pradhvan
Copy link
Copy Markdown
Member

Pradhvan commented Aug 3, 2020 •
edited
Loading

@camilamaia Yes, but if we squash and merge it still gives out

* Changed command `scanapi <spec_file>` to `scanapi run <spec_file>`.

* Added changes to changelog

* Fixed broken test

* Fix changelog lint rules

* Fix changelog lint rules

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Fixed Changelog Lint

This commit message is more or less noice for folks who aren't involved in the PR.

If the PR creator squashes and merges he/she/they can put a single appropriate commit message that can be really helpful for other people too who weren't involved in the PR. Something like:

Commit head : Change command "scanapi <spec_file>" to "scanapi run <spec_file>" 

Commit body: discription about how the issue was solved 

Closes which issue

( Do correct me if I am wrong)

PS: I tagged you spectrum thinking the notification won't go as the branch is deleted. So feel free to ignore that. :)

@camilamaia
Copy link
Copy Markdown
Member

camilamaia commented Aug 3, 2020

@Pradhvan hmm that makes sense. We can use this approach in the next PRs! I use a lot —amend command, so I am not that used with squash. Good to know 👍

@camilamaia camilamaia mentioned this pull request Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pradhvan Pradhvan Pradhvan approved these changes

@barbosa barbosa barbosa approved these changes

@camilamaia camilamaia camilamaia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abreumatheus @Pradhvan @camilamaia @barbosa