Skip to content

feat: Add workflow to package/publish to test PyPi#234

Closed
vinigfer wants to merge 2 commits intoscanapi:masterfrom
vinigfer:feat-upload-to-test-pypi
Closed

feat: Add workflow to package/publish to test PyPi#234
vinigfer wants to merge 2 commits intoscanapi:masterfrom
vinigfer:feat-upload-to-test-pypi

Conversation

@vinigfer
Copy link
Copy Markdown
Member

@vinigfer vinigfer commented Jul 26, 2020

Related issue: #146

@barbosa
Copy link
Copy Markdown
Member

barbosa commented Jul 26, 2020

@vinigfer The error with Changelog Reminder is a current limitation of GitHub Actions. The thing is that it won't run for forked repos unless you enable it to do so. See discussion here.

Workflows don't run on forked repositories by default. You must enable GitHub Actions in the Actions tab of the forked repository.

source: https://help.github.com/en/actions/reference/events-that-trigger-workflows

@barbosa
Copy link
Copy Markdown
Member

barbosa commented Jul 26, 2020

@camilamaia to differ a "test" version from a "production" version, we could potentially make use of pre-releases, or release candidates.

Before tagging a version that is intended to be published (say 1.5.0), we could create a few others to test on Test PyPi first (1.5.0-rc1, 1.5.0-rc2, ...). Then poetry would be able to publish a new version every time a new RC is created.

Later, we could also have an action that every time we push to master, it'd increment the RC version, commit and push the now updated pyproject.toml file, and publish this new version to Test PyPi. But I would leave this to another issue/PR.

We may also want to check this box when creating a release from GitHub:
Screen Shot 2020-07-26 at 10 57 06 AM

@vinigfer
Copy link
Copy Markdown
Member Author

Guys, closing this PR since can't change the source branch/repo. Continuing it here: #239

Like this approach of 1.5.0-rc1for Test PyPi versus 1.5.0 for both, and also agree to work on that on a next PR

@vinigfer vinigfer closed this Jul 26, 2020
@vinigfer vinigfer deleted the feat-upload-to-test-pypi branch July 26, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants