Remove the api top-level key#231
Merged
camilamaia merged 1 commit intoscanapi:masterfrom Jul 26, 2020
supakeen:remove-api-key
Merged
Remove the api top-level key#231camilamaia merged 1 commit intoscanapi:masterfrom supakeen:remove-api-key
api top-level key#231camilamaia merged 1 commit intoscanapi:masterfrom
supakeen:remove-api-key
Conversation
Member
|
PR that changes the examples: scanapi/examples#6 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #209 it was suggested to remove the top-level
apikey, this PR removes that but it does not deal with the possibility of it being there. Since for the previous PRs we let things ride regarding backwards compatibility I wonder if it's still necessary for this PR.Closes #209