Minor textual review of text files in the repo.#220
Merged
barbosa merged 2 commits intoscanapi:masterfrom Jul 25, 2020
supakeen:review-text
Merged
Minor textual review of text files in the repo.#220barbosa merged 2 commits intoscanapi:masterfrom supakeen:review-text
barbosa merged 2 commits intoscanapi:masterfrom
supakeen:review-text
Conversation
camilamaia
reviewed
Jul 25, 2020
Member
camilamaia
left a comment
There was a problem hiding this comment.
Thank you very much for the corrections! I left just minor comments
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [1.0.6] - 2020-07-25 |
Member
There was a problem hiding this comment.
Suggested change
| ## [1.0.6] - 2020-07-25 |
We keep all the changes under Unreleased section and only when we want in fact to create a new release, we move them to the proper release title, like this https://github.com/scanapi/scanapi/pull/212/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR10
So for now, we can leave everything under ##[Unreleased]
| [tool.poetry] | ||
| name = "scanapi" | ||
| version = "1.0.5" | ||
| version = "1.0.6" |
Member
There was a problem hiding this comment.
Suggested change
| version = "1.0.6" | |
| version = "1.0.5" |
Contributor
Author
|
I have updated the CHANGELOG format I misunderstood across my PR's :) |
barbosa
approved these changes
Jul 25, 2020
README.md - English grammar and readability fixes. CONTRIBUTING.md - Change `versions` link to point to a public link. - English grammar and readability fixes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.md
CONTRIBUTING.md
versionslink to point to a public link.