Merged
Conversation
|
@marcuxyz your pull request is missing a changelog! |
camilamaia
reviewed
Jul 13, 2020
Member
camilamaia
left a comment
There was a problem hiding this comment.
@marcuxyz First of all, thank you very much for the PR! 🙇♀️
To pass in the checks, you would need to:
- Format the files using black
- Add an entry to the CHANGELOG.md file.
- Change the publish to pypi github action, because it uses the old way with setup.py. I would suggest to use this action: https://github.com/marketplace/actions/publish-python-poetry-package
Please, let me know if you need help with any of these points!
camilamaia
reviewed
Jul 13, 2020
camilamaia
reviewed
Jul 13, 2020
Member
|
@marcuxyz Hmmm I was thinking that probably we need to update the |
gillianomenezes
approved these changes
Jul 13, 2020
Contributor
gillianomenezes
left a comment
There was a problem hiding this comment.
I didn't know poetry. Seems nice.
camilamaia
reviewed
Jul 15, 2020
|
@camilamaia your pull request is missing a changelog! |
169f5ef to
3ac93f3
Compare
4f1cbc4 to
d18a99c
Compare
d18a99c to
cef1d57
Compare
camilamaia
approved these changes
Jul 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #140
Close #141
Close #150