Vertically centered status icons#195
Merged
barbosa merged 2 commits intoscanapi:masterfrom Jun 26, 2020
abreumatheus:vertically_center_status_icons
Merged
Vertically centered status icons#195barbosa merged 2 commits intoscanapi:masterfrom abreumatheus:vertically_center_status_icons
barbosa merged 2 commits intoscanapi:masterfrom
abreumatheus:vertically_center_status_icons
Conversation
camilamaia
approved these changes
Jun 26, 2020
Member
camilamaia
left a comment
There was a problem hiding this comment.
Thank you very much for the PR!! 🙇♀️
Just a minor detail, but the way you prefer is good for me :)
| @@ -205,6 +205,9 @@ | |||
| color: white; | |||
| font-size: 14px; | |||
| line-height: 20px; | |||
Member
There was a problem hiding this comment.
Suggested change
| line-height: 20px; | |
| line-height: 19px; |
This is how it is rendering with your changes and line height 20px:
I tried to reduce 1px of the line height and this is the result:
What do you think?
Member
Author
There was a problem hiding this comment.
I don't know, with 20px it seems more aligned with the center of the arrow icon. It would be nice to hear other opinions on this.
Member
There was a problem hiding this comment.
True. 20 seems to better align with the arrow and 19/18 with the status code.
Anyways - I think this is good 👍
barbosa
approved these changes
Jun 26, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed