Skip to content

Handle properly exit errors and add test erros on report#187

Merged
camilamaia merged 2 commits intomasterfrom
106
Jun 22, 2020
Merged

Handle properly exit errors and add test erros on report#187
camilamaia merged 2 commits intomasterfrom
106

Conversation

@camilamaia
Copy link
Copy Markdown
Member

@camilamaia camilamaia commented Jun 21, 2020 •
edited
Loading

  • Handle properly exit errors
  • Add test errors to the report
  • Improve Error Message for Invalid Python code error

error-opened

Closes #104
Closes #105
Closes #106

@camilamaia camilamaia self-assigned this Jun 21, 2020
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 21, 2020

@camilamaia your pull request is missing a changelog!

@camilamaia camilamaia force-pushed the 106 branch 4 times, most recently from de0b3eb to a24e298 Compare June 21, 2020 23:56
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 21, 2020 •
edited
Loading

Codecov Report

Merging #187 into improve-html-report will decrease coverage by 0.25%.
The diff coverage is 85.91%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           improve-html-report     #187      +/-   ##
=======================================================
- Coverage                93.82%   93.57%   -0.26%     
=======================================================
  Files                       19       21       +2     
  Lines                      551      591      +40     
=======================================================
+ Hits                       517      553      +36     
- Misses                      34       38       +4
Impacted Files Coverage Δ
scanapi/tree/endpoint_node.py 85.24% <66.66%> (-0.97%) ⬇️
scanapi/tree/testing_node.py 88.23% <71.42%> (-11.77%) ⬇️
scanapi/scan.py 93.47% <78.57%> (-6.53%) ⬇️
scanapi/errors.py 94.11% <100.00%> (ø)
scanapi/evaluators/code_evaluator.py 100.00% <100.00%> (ø)
scanapi/evaluators/string_evaluator.py 95.45% <100.00%> (+10.83%) ⬆️
scanapi/exit_code.py 100.00% <100.00%> (ø)
scanapi/session.py 100.00% <100.00%> (ø)
scanapi/test_status.py 100.00% <100.00%> (ø)
scanapi/tree/request_node.py 98.33% <100.00%> (+0.02%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c629f...ee992fd. Read the comment docs.

@camilamaia camilamaia marked this pull request as ready for review June 22, 2020 00:02
@camilamaia camilamaia changed the title Handle properly exit errors and test erros on report Handle properly exit errors and add test erros on report Jun 22, 2020
gillianomenezes
gillianomenezes approved these changes Jun 22, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@gillianomenezes gillianomenezes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from improve-html-report to master June 22, 2020 21:37
@camilamaia camilamaia merged commit b38ebbb into master Jun 22, 2020
@camilamaia camilamaia deleted the 106 branch June 22, 2020 21:38
@camilamaia camilamaia mentioned this pull request Jun 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gillianomenezes gillianomenezes gillianomenezes approved these changes

@barbosa barbosa Awaiting requested review from barbosa

Assignees

@camilamaia camilamaia

Labels

None yet

Projects

None yet

Milestone

No milestone

3 participants

@camilamaia @codecov-commenter @gillianomenezes