Merged
Conversation
|
@camilamaia your pull request is missing a changelog! |
69df081 to
5e873a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 91.92% 93.68% +1.75%
==========================================
Files 14 16 +2
Lines 508 538 +30
==========================================
+ Hits 467 504 +37
+ Misses 41 34 -7
Continue to review full report at Codecov.
|
42375c1 to
b381132
Compare
2255e6d to
6f8411b
Compare
7663634 to
d5d8c11
Compare
edff481 to
e1da6fd
Compare
| @@ -0,0 +1,19 @@ | |||
| import curlify | |||
Contributor
There was a problem hiding this comment.
I like how this refactor follows the Single Responsibility Principle 😃
Contributor
There was a problem hiding this comment.
I mean the entire class
| env.globals["project_name"] = settings.get("project-name", "") | ||
| chosen_template = env.get_template(template_path) | ||
| return chosen_template.render(responses=responses) | ||
| def _build_context(self, results): |
Contributor
There was a problem hiding this comment.
Excellent refactor! It turned to be easier to read 🔍
Member
Author
|
@gillianomenezes thank you very much for the comments and feedbacks!!! 🎉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current this is how it is rendered: https://github.com/scanapi/scanapi/blob/adr2/testing_reports/current.html
But we are still discussing better how we are going to present it #161 . We can improve it later in the next PRs.
Closes #169
Closes #167