Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files          12       12           
  Lines         462      462           
=======================================
  Hits          427      427           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50fdd1...d83aaa4. Read the comment docs.

You may also want to add HTML as the default option on __init__.py

@barbosa I believe we cannot do that. If reporter is set as markdown in the config file and not via console, we would overwrite it with html anyway.

@camilamaia Hmm I see. So maybe we have a design issue here? Some arguments have their default value set via click and others via Settings, is that it?

@barbosa maybe... we have a priority here:

1st: options from click
2nd: options from config path

https://github.com/scanapi/scanapi/blob/master/scanapi/settings.py#L40-L41

Talking with examples: If i set key x in the config file as 1, and i set the same key x via console as 2, the program should consider the console more important and set key x as 2

That is why we cannot use the default values from click. This logic is applied for all arguments.

Do you see this as a problem? Can you think in a different way to do that? Thanks!

@barbosa I will merge this, but let's keep discussing it here, ok? If we think something needs to be done, I can create a new issue for it.