Skip to content

Unified keys validation in a single method#151

Merged
camilamaia merged 1 commit intomasterfrom
validate-keys
May 27, 2020
Merged

Unified keys validation in a single method#151
camilamaia merged 1 commit intomasterfrom
validate-keys

Conversation

@camilamaia
Copy link
Copy Markdown
Member

@camilamaia camilamaia commented May 24, 2020 •
edited
Loading

Description

  • Unified keys validation in a single method

Every time we were running scanapi, it was returning this error:

INFO:scanapi.config_loader:Loading file .scanapi.yaml
INFO:scanapi.config_loader:Loading file api.yaml
ERROR:scanapi:Error loading API spec. Missing 'name', 'requests', key(s) at 'endpoint' scope
  • This PR fixes it too.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 24, 2020 •
edited
Loading

Codecov Report

Merging #151 into master will increase coverage by 0.17%.
The diff coverage is 97.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   91.37%   91.54%   +0.17%     
==========================================
  Files          11       11              
  Lines         394      402       +8     
==========================================
+ Hits          360      368       +8     
  Misses         34       34
Impacted Files Coverage Δ
scanapi/tree/endpoint_node.py 83.63% <92.30%> (+1.28%) ⬆️
scanapi/errors.py 94.11% <100.00%> (ø)
scanapi/tree/request_node.py 98.11% <100.00%> (-0.04%) ⬇️
scanapi/tree/tree_keys.py 100.00% <100.00%> (ø)
scanapi/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a59fe...b19b924. Read the comment docs.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 24, 2020

@camilamaia your pull request is missing a changelog!

@camilamaia camilamaia changed the title Unified validated keys Unified keys validation in a single method May 24, 2020
@camilamaia camilamaia marked this pull request as ready for review May 24, 2020 17:20
@camilamaia camilamaia self-assigned this May 24, 2020
@camilamaia camilamaia added the Refactor Refactors the current code label May 24, 2020
@camilamaia camilamaia force-pushed the validate-keys branch 2 times, most recently from 0c7ba6a to 4ac9dd3 Compare May 24, 2020 17:31
@camilamaia camilamaia added the Bug Something isn't working label May 25, 2020
@camilamaia camilamaia force-pushed the validate-keys branch 2 times, most recently from 2b95986 to 7b85f08 Compare May 27, 2020 22:09
@camilamaia camilamaia merged commit 00074b4 into master May 27, 2020
@camilamaia camilamaia deleted the validate-keys branch May 27, 2020 22:22
@camilamaia camilamaia mentioned this pull request Jun 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gillianomenezes gillianomenezes Awaiting requested review from gillianomenezes

@barbosa barbosa Awaiting requested review from barbosa

Assignees

@camilamaia camilamaia

Labels

Bug Something isn't working Refactor Refactors the current code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camilamaia @codecov-commenter