Skip to content

Automated PyPI deploy with Github Actions#144

Merged
camilamaia merged 3 commits intomasterfrom
pypi-automation
May 14, 2020
Merged

Automated PyPI deploy with Github Actions#144
camilamaia merged 3 commits intomasterfrom
pypi-automation

Conversation

@camilamaia
Copy link
Copy Markdown
Member

@camilamaia camilamaia commented May 13, 2020

Description

Automated PyPI deploy with Github Actions

Reference: https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

Closes #36

We can test it properly in the next release

@camilamaia camilamaia requested a review from barbosa May 13, 2020 12:48
@camilamaia
Copy link
Copy Markdown
Member Author

We need to setup a pyproject.toml file 😞

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 13, 2020

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files          11       11           
  Lines         381      381           
=======================================
  Hits          348      348           
  Misses         33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 676b662...03702bb. Read the comment docs.

uses: pypa/gh-action-pypi-publish@master
with:
user: __token__
password: ${{ secrets.pypi_password }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to publish to Test Pypi too?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm good point, I was lazy and ignored it 😆

It makes sense to have it. But I believe in a step before, right? I mean, not in the release process. Cause then we can test it before sending to "production".

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. We'd need another workflow.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barbosa I created a issue for that #146

@camilamaia camilamaia merged commit d7da858 into master May 14, 2020
@camilamaia camilamaia deleted the pypi-automation branch May 14, 2020 13:24
This was referenced May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploying to PyPI with Github Actions

3 participants