Skip to content

Refactor: settings#128

Merged
camilamaia merged 2 commits intomasterfrom
settings
May 9, 2020
Merged

Refactor: settings#128
camilamaia merged 2 commits intomasterfrom
settings

Conversation

@camilamaia
Copy link
Copy Markdown
Member

@camilamaia camilamaia commented May 7, 2020

Description

  • Add CLI option to pass a configuration file path
  • Fix error message when spec file was not found
  • Refactor: settings

Closes #122
Closes #123

@camilamaia camilamaia force-pushed the settings branch 2 times, most recently from 11a1c26 to 54e5b8e Compare May 8, 2020 12:43
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 8, 2020

Codecov Report

Merging #128 into master will increase coverage by 1.41%.
The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   82.60%   84.02%   +1.41%     
==========================================
  Files          11       11              
  Lines         368      388      +20     
==========================================
+ Hits          304      326      +22     
+ Misses         64       62       -2     
Impacted Files Coverage Δ
scanapi/reporter.py 27.50% <33.33%> (ø)
scanapi/settings.py 100.00% <100.00%> (+20.00%) ⬆️
scanapi/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 235dd95...37cb0ea. Read the comment docs.

@camilamaia camilamaia force-pushed the settings branch 2 times, most recently from 6ff52b0 to 7dd7938 Compare May 8, 2020 13:38
@camilamaia camilamaia marked this pull request as ready for review May 8, 2020 22:50
@camilamaia camilamaia merged commit a5a9354 into master May 9, 2020
@camilamaia camilamaia deleted the settings branch May 9, 2020 16:46
@camilamaia camilamaia mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix error message when spec file was not found Create a CLI option to pass a configuration file path

3 participants