Skip to content

Enable to have API spec in multiples files#125

Merged
camilamaia merged 4 commits intomasterfrom
multiple-spec
May 5, 2020
Merged

Enable to have API spec in multiples files#125
camilamaia merged 4 commits intomasterfrom
multiple-spec

Conversation

@camilamaia
Copy link
Copy Markdown
Member

@camilamaia camilamaia commented May 1, 2020

Description

  • Enable to have API spec in multiples files
  • Add API spec JSON compatibility to README.md

Closes #10
Closes #124

@camilamaia camilamaia added the Feature New feature or request label May 1, 2020
@camilamaia camilamaia requested review from barbosa and djalmaaraujo May 1, 2020 22:02
@camilamaia camilamaia marked this pull request as ready for review May 1, 2020 22:20
Comment thread scanapi/yaml_loader.py
if not data:
raise EmptySpecError

return data
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it still makes sense to call this file yaml_loader since now it also loads json.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Actually I implemented this change in another PR to avoid making this too big #127

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread scanapi/yaml_loader.py Outdated
Because we can also have config files as JSON
Copy link
Copy Markdown
Member

@barbosa barbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@camilamaia camilamaia merged commit 235dd95 into master May 5, 2020
@camilamaia camilamaia deleted the multiple-spec branch May 5, 2020 17:37
@camilamaia camilamaia mentioned this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add API spec JSON compatibility to README.md Enable to have API spec in multiples files

3 participants