Skip to content

Refactor Architecture#116

Merged
camilamaia merged 22 commits intomasterfrom
nodes_refactor
Apr 22, 2020
Merged

Refactor Architecture#116
camilamaia merged 22 commits intomasterfrom
nodes_refactor

Conversation

@camilamaia
Copy link
Copy Markdown
Member

@camilamaia camilamaia commented Mar 22, 2020 •
edited
Loading

Description

First of all, sorry for the biggest PR ever 🐘 Next time I will create another branch and smaller PRs.

This refactors the whole code to use a cleaner and better recursion mechanism.

Also, it changes a bit the syntax of the API specification to make it easier the recursion. This way, we don't need to handle the root cases and different keywords from different scopes with the same meaning (like base_url and path).

Summary:

  • Refactor: endpoints recursion mechanism
  • Refactor: fix reporter
  • Refactor: readd env variable parser
  • Add ipdb
  • Refactor: readd headers implementation
  • Refactor: create refactor folder; split files
  • Refactor: readd headers evaluation
  • Refactor: rename namespace key to name for endpoint node
  • Refactor: readd body to request node
  • Refactor: endpoint node tests
  • Update CHANGELOG.md
  • Refactor: readd params
  • Refactor: readd code evaluator
  • Refactor: readd hide sensitive info
  • Refactor: readd vars
  • Refactor: readd check for ALLOWED_HTTP_METHODS
  • Refactor: readd exception handling when making request
  • Refactor: readd validate spec keys
  • Refactor: delete old code
  • Refactor: remove refactor folder
  • Remove factory boy and pytest-bdd
  • Refactor: update readme with new ScanAPI syntax
  • Refactor: add log for making requests

Issues

Add hide sensitive info to body #31

@camilamaia camilamaia added the Refactor Refactors the current code label Mar 22, 2020
@camilamaia camilamaia self-assigned this Mar 22, 2020
@camilamaia camilamaia force-pushed the nodes_refactor branch 2 times, most recently from 67e86ec to 533a204 Compare March 23, 2020 12:12
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 24, 2020 •
edited
Loading

Codecov Report

Merging #116 into master will decrease coverage by 2.23%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   90.18%   87.95%   -2.24%     
==========================================
  Files          14       15       +1     
  Lines         377      415      +38     
==========================================
+ Hits          340      365      +25     
- Misses         37       50      +13
Impacted Files Coverage Δ
scanapi/reporter.py 63.15% <ø> (+1.61%) ⬆️
scanapi/refactor/evaluators/spec_evaluator.py 70.00% <70.00%> (ø)
scanapi/refactor/evaluators/string_evaluator.py 84.31% <84.31%> (ø)
scanapi/refactor/tree/endpoint_node.py 91.66% <91.66%> (ø)
scanapi/refactor/tree/request_node.py 97.56% <97.56%> (ø)
scanapi/refactor/evaluators/code_evaluator.py 100.00% <100.00%> (ø)
scanapi/refactor/utils.py 100.00% <100.00%> (ø)
scanapi/tree/endpoint_node.py
scanapi/evaluators/spec_evaluator.py
scanapi/evaluators/code_evaluator.py
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13b15b...8ab4c3a. Read the comment docs.

@camilamaia camilamaia force-pushed the nodes_refactor branch 2 times, most recently from 45e8368 to af91d0e Compare March 24, 2020 12:23
@camilamaia camilamaia force-pushed the nodes_refactor branch 3 times, most recently from 990c4dc to e84a45c Compare April 21, 2020 12:13
@camilamaia camilamaia marked this pull request as ready for review April 21, 2020 12:15
@camilamaia camilamaia changed the title Refactor: Refactor Architecture Apr 21, 2020
@camilamaia camilamaia merged commit dbd4b9e into master Apr 22, 2020
@camilamaia camilamaia deleted the nodes_refactor branch April 22, 2020 16:20
@camilamaia camilamaia mentioned this pull request May 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barbosa barbosa barbosa approved these changes

@winstonf88 winstonf88 Awaiting requested review from winstonf88

@dubirajara dubirajara Awaiting requested review from dubirajara

@djalmaaraujo djalmaaraujo Awaiting requested review from djalmaaraujo

Assignees

@camilamaia camilamaia

Labels

Refactor Refactors the current code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@camilamaia @codecov-io @barbosa @winstonf88