Barcelona | OTC-2025-2 | Sahim Saami | Sprint 4 | Implement shell tools - #7
Open
sahimsaami wants to merge 5 commits into
Open
Barcelona | OTC-2025-2 | Sahim Saami | Sprint 4 | Implement shell tools#7sahimsaami wants to merge 5 commits into
sahimsaami wants to merge 5 commits into
Conversation
| const folder = args.find(a => !a.startsWith("-")) || "."; | ||
|
|
||
| let files = fs.readdirSync(dir); | ||
| let files = fs.readdirSync(folder); |
There was a problem hiding this comment.
ls output is typically sorted. You should apply: files.sort();
Owner
Author
There was a problem hiding this comment.
Thanks,
added the files.sort() and its working
|
|
||
| const lines = text.split("\n").length; | ||
| const words = text.trim().split(/\s+/).filter(Boolean).length; | ||
| const words = text.trim().split(/\s+/).length; |
There was a problem hiding this comment.
If the file is empty, this returns 1 instead of 0 because split() on an empty string still produces [""].
maybe const words = text.trim() ? text.trim().split(/\s+/).length : 0;
Owner
Author
There was a problem hiding this comment.
fix: handle empty files correctly in wc
yassineyahya-occ
left a comment
There was a problem hiding this comment.
Overall structure is clean and readable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist