Skip to content

Barcelona | OTC-2025-2 | Sahim Saami | Sprint 1 |Feature/shell tools - #1

Open
sahimsaami wants to merge 6 commits into
mainfrom
feature/shell-tools
Open

Barcelona | OTC-2025-2 | Sahim Saami | Sprint 1 |Feature/shell tools#1
sahimsaami wants to merge 6 commits into
mainfrom
feature/shell-tools

Conversation

@sahimsaami

Copy link
Copy Markdown
Owner

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

@sahimsaami sahimsaami added help wanted Extra attention is needed Need to review labels Mar 22, 2026

# TODO: Write a command to output every line in dialogue.txt said by the Doctor.
# The output should contain 6 lines.
grep "the Doctor" dialogue.txt No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should ensure you match “Doctor” as a format , not "the Doctor".

# TODO: Write a command to output every line in dialogue.txt that does not contain the word "Hello" (regardless of case).
# The output should contain 10 lines.
grep -iv "Hello" dialogue.txt // The output should be the number 10.
grep -ivc "Hello" dialogue.txt No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You included two commands in the same script, but the exercise expects only one command.
The required output is the 10 lines, not the number.

@yassineyahya-occ yassineyahya-occ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work overall. Be careful with -c vs printing lines and ensure each script has only one correct command matching the requirement. :)

@sahimsaami

Copy link
Copy Markdown
Owner Author

Hello dear Yassin I fixed the errors .
Thank you so mach for your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed Need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants