Skip to content

add ingress class - #55

Open
hussein-firas wants to merge 1 commit into
rudderlabs:masterfrom
hussein-firas:add-ingress-class
Open

add ingress class#55
hussein-firas wants to merge 1 commit into
rudderlabs:masterfrom
hussein-firas:add-ingress-class

Conversation

@hussein-firas

Copy link
Copy Markdown

Description of the change

Description here

Add the option to specify the ingress class (important for Nginx ingress controller, and if you have multiple ingress controller running in the cluster)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@gitcommitshow

Copy link
Copy Markdown
Contributor

Thank you for your contribution @husseinferas , please sign this CLA so the team can go ahead with the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants