Skip to content

Feature/250 add pyright #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isabelizimm merged 18 commits into from
Jul 25, 2024
Merged

Feature/250 add pyright #256

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0e0ee92
Add a new `check` extra including `pyright` and `pre-commit`.
nathanjmcdougall Jul 19, 2024
4ec2841
Configure pyright to run in CI.
nathanjmcdougall Jul 19, 2024
a3253cc
Use pyright action v2
nathanjmcdougall Jul 19, 2024
0a6061b
Install dependencies before running pyright.
nathanjmcdougall Jul 19, 2024
4762898
Fix sync error.
nathanjmcdougall Jul 19, 2024
2105df0
Revert unnecessary bumps in dev.txt
nathanjmcdougall Jul 20, 2024
e6189d4
Ignore the tests folder correctly.
nathanjmcdougall Jul 20, 2024
986a98b
Add appdirs stubs
nathanjmcdougall Jul 20, 2024
ebd603e
Re-enable reportUnusedExpression
nathanjmcdougall Jul 20, 2024
de4646a
Add triaging comments for rule disables
nathanjmcdougall Jul 20, 2024
e2a0641
Revert unnecessary project.toml formatting change
nathanjmcdougall Jul 20, 2024
8e34560
Revert unnecessary indentation in dev.txt
nathanjmcdougall Jul 20, 2024
70f3742
Merge branch 'main' into feature/250-add-pyright
isabelizimm Jul 23, 2024
bbeb3dc
Update pyproject.toml
nathanjmcdougall Jul 23, 2024
839f558
Move pyright comments to a tracking issue.
nathanjmcdougall Jul 23, 2024
39b227b
Revert removal of config sections in pyproject.toml.
nathanjmcdougall Jul 23, 2024
09c2b1d
Merge branch 'main' into dev-feature-250-add-pyright
isabelizimm Jul 25, 2024
180c2bf
add check deps into toml
isabelizimm Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use pyright action v2
  • Loading branch information
@nathanjmcdougall
nathanjmcdougall committed Jul 19, 2024
commit a3253cc985560437873241d8ca349acfbcd48a41
2 changes: 1 addition & 1 deletion .github/workflows/code-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: jakebailey/pyright-action@v1
- uses: jakebailey/pyright-action@v2
with:
version: 1.1.273 # Manually sync with setup.cfg