Use dropdowns for Terms - #11
Closed
knowler wants to merge 11 commits into
Closed
Conversation
Member
Author
|
Bad news: markdown doesn’t seem to work in dropdown labels. Good news: they don’t select anything by default.
|
Member
Author
|
A little small, but I think this is good.
|
knowler
marked this pull request as ready for review
January 4, 2022 05:07
Member
|
definitely looks great on the form 👍 i didn't think about how this would look once an issue is submitted, see https://github.com/retlehs/issue-forms-qa/issues/3 🤔 |
Member
Author
|
I guess we could maybe set the "Yes" text to be a more descriptive of what they are agreeing to? |
Member
Author
|
I'll update the feature request dropdown text shortly. This doesn’t seem to bad even though it’s long:
|
Member
|
Revisited in #16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2
I’ve just added dropdowns for the bug report’s terms. If we like this, then I can add it to the feature request one as well. Also, I think I’m missing a heading for the terms.
There’s just one option for each dropdown since if there was a "no" then the field validation wouldn’t stop it from being submitted. I actually don't know if it leaves the default as blank, so this might not work.