Custom Test Settings a.k.a. Test Metadata#5281
Open
DanielSeim wants to merge 7 commits intorobotframework:masterfrom
Open
Custom Test Settings a.k.a. Test Metadata#5281DanielSeim wants to merge 7 commits intorobotframework:masterfrom
DanielSeim wants to merge 7 commits intorobotframework:masterfrom
Conversation
Member
|
Thanks for the PR. In order to get RF 7.2 out still this year, we decided to move this functionality to RF 7.3 that we start developing right after the new year. Because I need to concentrate on 7.2, I won't have time to properly review this until it is in the release candidate phase. I took a quick look at the changes, though, and here are quick comments based on that:
|
Contributor
|
Hello @DanielSeim is there a way i can help you out with this functionality ? Do you need a hand on anything regarding ? |
Author
|
FYI i will change the loading of the custom settings to cli options to get rid of the toml dependency as clarified at robocon. |
Member
|
The PR has merge conflicts that must be resolved before further evaluation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Pekka,
here is the first PR regarding the ticket #4409 custom test settings a.k.a. test metadata.
Please have a look at it. Tests will follow soon for the metadata setting.
After that i will implement the custom settings: See also #4409 (comment) bullet points 5 and 6.
Best regards,
Daniel Seim