Relax idna pin from ==3.7 to >=3.7 - #504
Merged
Merged
Conversation
idna is a transitive dependency (via requests) and is not imported anywhere in the SDK; the exact pin existed only to enforce the CVE-2024-3651 security floor (fixed in idna 3.7, added by Dependabot). The exact `==3.7` propagates to every package that installs `roboflow` and forces the resolver to backtrack when a sibling dependency (e.g. google-cloud) needs a newer idna — this is the root cause worked around in roboflow-queues#121. Relaxing to `>=3.7` keeps the security floor while letting the resolver pick a compatible newer idna (requests caps it at <4). Matches requirements-slim.txt, which already leaves idna unpinned. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
iurisilvio
force-pushed
the
fix/unpin-idna
branch
from
July 3, 2026 14:23
265cc75 to
3d5ccf0
Compare
This was referenced Jul 3, 2026
digaobarbosa
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Relax the
idnarequirement from an exact pin==3.7to a floor>=3.7.Why
idnais a transitive dependency (pulled in viarequests) and is not imported anywhere in the SDK. The line exists solely to enforce the security floor from CVE-2024-3651 (fixed in idna 3.7, originally added by Dependabot).Because
setup.pyreadsrequirements.txtline-by-line intoinstall_requires, the exact==3.7propagates to every project that installsroboflow. Any downstream environment that also depends on a package requiring a neweridna(e.g. thegoogle-cloud-*stack) hits resolver backtracking or an outright conflict, sinceidnais nailed to exactly3.7.Relaxing to
>=3.7:requestscapsidna<4, so this resolves to the latest3.x.requirements-slim.txt, which already leavesidnaunpinned.Notes
idnais not referenced in application code, so there is no runtime behavior change — this only affects dependency resolution.🤖 Generated with Claude Code