release-download-count - Restore support for GitHub Enterprise#9636
Merged
Conversation
GHES DOM looks like ``` <span .../> <!-- SHA1 --> <span .../> <!-- SHA1 copy button --> <span .../> <!-- Size --> <span .../> <!-- Date --> ``` while github.com DOM has a nested `<div>`: ``` <div> <span .../> <!-- SHA1 --> <span .../> <!-- SHA1 copy button --> </div> <span .../> <!-- Size --> <span .../> <!-- Date --> ``` This change: - Fixes finding the assetSize column - Fixes CSS by excluding the copy button column (data-view-component) for fixed-width (min-size) columns, which would become too large otherwise. Closes refined-github#9210.
e049ba9 to
a711fe3
Compare
|
Please avoid force-pushing to this PR. It makes it harder for reviewers to track what changed since the last review. Just push new commits on top of the branch instead — PRs are squashed on merge, so the commit history doesn't need to be clean. |
Member
|
Tested, I see no regressions. I see a pre-existing bug though: |
release-download-count on GHESrelease-download-count - Restore support for GitHub Enterprise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
release-download-counton GHESGHES DOM looks like
while github.com DOM has a nested
<div>:This change:
Fixes finding the assetSize column
Fixes CSS by excluding the copy button column (data-view-component)
for fixed-width (min-size) columns, which would become too large
otherwise.
Closes #9210.