Skip to content

repo-avatars - Various fixes - #8971

Merged
fregante merged 2 commits into
mainfrom
repo-avatar
Feb 13, 2026
Merged

repo-avatars - Various fixes#8971
fregante merged 2 commits into
mainfrom
repo-avatar

Conversation

@SunsetTechuila

@SunsetTechuila SunsetTechuila commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the bug label Feb 11, 2026
SunsetTechuila
SunsetTechuila commented Feb 11, 2026
View reviewed changes
Comment thread source/features/repo-avatars.tsx
ownerLabel.prepend(avatar);

if (!ownerLabel.closest('[data-hovercard-type="organization"]')) {
if (!pageDetect.isOrganizationRepo()) {

@SunsetTechuila SunsetTechuila Feb 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken

@SunsetTechuila SunsetTechuila Feb 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refined-github/github-url-detection#231

@fregante

fregante commented Feb 12, 2026

Copy link
Copy Markdown
Member

Can be merged after you install the URL detection update (after that PR is merged)

@SunsetTechuila

SunsetTechuila commented Feb 12, 2026

Copy link
Copy Markdown
Contributor Author

Can be merged after you install the URL detection update

That would also affect user-profile-follower-badge - #8952

Shouldn't this be a separate PR?

@SunsetTechuila SunsetTechuila mentioned this pull request Feb 12, 2026
Merged
@fregante

fregante commented Feb 12, 2026

Copy link
Copy Markdown
Member

Ok then. But merge that one before this one since this PR as is does not fix the feature (from what I understand)

@SunsetTechuila

SunsetTechuila commented Feb 12, 2026

Copy link
Copy Markdown
Contributor Author

this PR as is does not fix the feature (from what I understand)

refined-github/github-url-detection#230 fixed #8952

image

@fregante

fregante commented Feb 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Does this PR fix #8968 without updating the package?

@SunsetTechuila

SunsetTechuila commented Feb 13, 2026

Copy link
Copy Markdown
Contributor Author

Yes, updating github-url-detection will only make organization avatars non-circular

@fregante

fregante commented Feb 13, 2026

Copy link
Copy Markdown
Member

What does this comment mean? It's broken or not? #8971 (comment)

@SunsetTechuila

SunsetTechuila commented Feb 13, 2026

Copy link
Copy Markdown
Contributor Author

isOrganizationRepo is broken but this feature uses it only to decide the avatar shape

@fregante
fregante merged commit 30ba70e into main Feb 13, 2026
8 checks passed
@fregante
fregante deleted the repo-avatar branch February 13, 2026 13:56
@SunsetTechuila SunsetTechuila mentioned this pull request Mar 3, 2026
Merged
@fregante fregante mentioned this pull request May 22, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fregante fregante fregante approved these changes

Assignees

No one assigned

Labels

bug

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

repo-avatars misaligns breadcrumbs, appends avatar to their overflow menu multiple times

2 participants

@SunsetTechuila @fregante