show-names - Restore for some elements & fix spacing - #8970
Merged
SunsetTechuila merged 17 commits intoMar 1, 2026
Conversation
mschoettle
force-pushed
the
mschoettle-patch-1
branch
from
February 11, 2026 16:10
8bc9b6f to
c2d43ac
Compare
show-names: Add margin for names in comment context
show-names: Add margin for names in comment contextshow-names: Add margin for names outside comment context
mschoettle
marked this pull request as ready for review
February 11, 2026 17:23
show-names: Add margin for names outside comment contextshow-names - Fix spacing in conversation events
fregante
approved these changes
Feb 12, 2026
SunsetTechuila
force-pushed
the
mschoettle-patch-1
branch
from
February 15, 2026 15:29
0f81c6d to
518265e
Compare
Member
|
If would be good to include a comment with the test URL in each block, plus ideally a description of what to look for. Long conditions like these can become hard to parse and test later on. |
Contributor
Author
|
I just tried out the latest changes and can confirm that it works. Thanks. |
Contributor
|
|
show-names - Fix spacing in conversation eventsshow-names - Enable for issue events & fix spacing in conversation events
show-names - Enable for issue events & fix spacing in conversation eventsshow-names - Restore for some elements & fix spacing in conversation events
show-names - Restore for some elements & fix spacing in conversation eventsshow-names - Restore for some elements & fix spacing
SunsetTechuila
force-pushed
the
mschoettle-patch-1
branch
from
February 28, 2026 01:11
d8584e8 to
253b62a
Compare
fregante
approved these changes
Feb 28, 2026
Contributor
|
@mschoettle Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is margin missing on the inserted name element for timeline items like "User added some commits" or "User force-pushed".
It is only missing on non-comments and those without
.markdown-title(since they have their own CSS rule to change it to a flex container with gap).Test URLs
isHome&isFeedgithub-url-detection#235)Screenshot