Meta: Avoid failing silently for DOM searches #8863

Copilot · 2026-01-10T07:23:37Z

Selective migration of select-dom imports to select-dom/strict.js for better type safety, while preserving non-strict utilities based on codebase conventions.

Changes

Selective import migration (~20 files):
- $$ → $$ from strict (when elements are guaranteed to exist and should throw if not found)
- $$optional from strict (when elements may not exist, e.g., reactions, optional UI elements)
- lastElement(selector) → lastElementOptional(selector) (when null-checked)
- Used strict $ where non-null assertions (!) were already used
Preserved non-strict utilities:
- Kept elementExists from non-strict 'select-dom' (42+ files unchanged)
- Kept countElements from non-strict 'select-dom' where used
- Kept $$ from non-strict in files where iteration over potentially empty arrays is the expected behavior (deep-reblame only)
Code quality fixes:
- Removed all aliasing patterns (never use $$optional as $$)
- Maintained original import order with external imports near the top
- Consolidated duplicate imports across files

Example

# Use strict $$ where elements must exist (throws if not found)
- import {$$} from 'select-dom';
+ import {$$} from 'select-dom/strict.js';

# Use $$optional where elements may not exist (returns empty array)
- import {$$} from 'select-dom';
+ import {$$optional} from 'select-dom/strict.js';
- for (const reaction of $$(selector)) { ... }
+ for (const reaction of $$optional(selector)) { ... }

# Keep non-strict utilities unchanged
import {elementExists, countElements} from 'select-dom';
if (elementExists('.some-selector')) { ... }
const count = countElements('.items');

Files retain non-strict imports for elementExists, countElements, and ElementNotFoundError (not exported by strict version). Migration uses:

Strict $$ where elements are guaranteed to exist (closing-remarks, token-validation, and 11 other files)
$$optional where elements may not exist (highest-rated-comment for reactions, etc.)

Test URLs

Affects all pages where features use DOM selection. Tested on:

Screenshot

N/A - Internal refactoring with no UI changes

Original prompt

Replace all select-dom imports with select-dom/strict. If ! is used, then just use the strict version ($, $$); if there's an extistence check, use $optional, etc

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Fix duplicate imports and TypeScript errors Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

All select-dom imports now use select-dom/strict.js with proper mappings: - $$ → $$optional (aliased as $$ for minimal changes) - elementExists → $optional - countElements → $$optional().length - lastElement → lastElementOptional (when checking for null) Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

source/features/actionable-pr-view-file.tsx

source/features/batch-mark-files-as-viewed.tsx

source/features/deep-reblame.tsx

…order - Reverted actionable-pr-view-file.tsx to use elementExists - Changed batch-mark-files-as-viewed.tsx to use $$ (strict) without aliasing - Restored import order in deep-reblame.tsx Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

- Reverted 42 files to use elementExists from 'select-dom' - Removed all '$$optional as $$' aliasing, using actual function names - Fixed import order in multiple files - Updated all usage to match new import patterns Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

source/features/clean-repo-tabs.tsx

source/features/close-out-of-view-modals.tsx

source/features/closing-remarks.tsx

source/features/cross-deleted-pr-branches.tsx

source/options/feature-list.tsx

source/options/token-validation.tsx

source/options.tsx

- Reverted clean-repo-tabs.tsx to use countElements (non-strict) - Reverted deep-reblame.tsx to use $$ from non-strict select-dom - Reverted token-validation.tsx to use $$ from non-strict select-dom - Reverted closing-remarks.tsx completely (imports and usage) - Changed $$optional to $$ (strict) in files where elements always exist: - close-out-of-view-modals.tsx - cross-deleted-pr-branches.tsx - hidden-review-comments-indicator.tsx - highest-rated-comment.tsx - no-duplicate-list-update-time.tsx - open-issue-to-latest-comment.tsx - quick-comment-hiding.tsx - release-download-count.tsx - click-all.ts - feature-list.tsx (3 instances) - options.tsx Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

- Changed from non-strict $$ to strict $$ (as intended) - Moved import to correct position with other external imports (line 3) - Consolidated imports: {$, $$} from 'select-dom/strict.js' Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

source/features/closing-remarks.tsx

source/features/highest-rated-comment.tsx

source/options/token-validation.tsx

- closing-remarks.tsx: Changed from non-strict to strict $$ import - token-validation.tsx: Changed from non-strict to strict $$ import - Both files now use: import {$, $$} from 'select-dom/strict.js' Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

…exist - Changed line 43 from $$ to $$optional for positiveReactionsSelector - Changed line 95 from $$ to $$optional in selectSum function - Added $$optional to imports - Reactions may not exist on the page, so $$optional is appropriate Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

fregante · 2026-01-26T09:41:15Z

(placeholder for issue)

Initial plan

10741ea

Copilot AI assigned Copilot and fregante Jan 10, 2026

Copilot started work on behalf of fregante January 10, 2026 07:24 View session

Copilot AI and others added 4 commits January 10, 2026 07:35

Migrate select-dom imports to strict - first batch

80460e6

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Migrate select-dom imports to strict - complete migration

bb57775

Fix duplicate imports and TypeScript errors Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Fix TypeScript errors - complete select-dom/strict migration

248169d

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Replace select-dom imports with select-dom/strict~~ Migrate all select-dom imports to select-dom/strict Jan 10, 2026

Copilot AI requested a review from fregante January 10, 2026 07:52

Copilot finished work on behalf of fregante January 10, 2026 07:52

fregante reviewed Jan 10, 2026

View reviewed changes

source/features/actionable-pr-view-file.tsx Outdated Show resolved Hide resolved

source/features/batch-mark-files-as-viewed.tsx Outdated Show resolved Hide resolved

source/features/deep-reblame.tsx Outdated Show resolved Hide resolved

Copilot started work on behalf of fregante January 10, 2026 08:42 View session

Copilot AI and others added 2 commits January 10, 2026 08:47

Copilot AI changed the title ~~Migrate all select-dom imports to select-dom/strict~~ Migrate select-dom imports to select-dom/strict (partial) Jan 10, 2026

Copilot AI requested a review from fregante January 10, 2026 08:53

Copilot finished work on behalf of fregante January 10, 2026 08:53

fregante changed the title ~~Migrate select-dom imports to select-dom/strict (partial)~~ Meta: Turn silent errors loud Jan 10, 2026

fregante changed the title ~~Meta: Turn silent errors loud~~ Meta: Fail loudly Jan 10, 2026

fregante reviewed Jan 10, 2026

View reviewed changes

Copilot started work on behalf of fregante January 10, 2026 09:18 View session

Copilot AI requested a review from fregante January 10, 2026 09:24

Copilot finished work on behalf of fregante January 10, 2026 09:24

Copilot started work on behalf of fregante January 10, 2026 09:56 View session

Copilot finished work on behalf of fregante January 10, 2026 09:59

Discard changes to source/features/closing-remarks.tsx

4d8eba1

fregante reviewed Jan 10, 2026

View reviewed changes

source/features/closing-remarks.tsx Outdated Show resolved Hide resolved

source/features/highest-rated-comment.tsx Outdated Show resolved Hide resolved

source/options/token-validation.tsx Outdated Show resolved Hide resolved

Copilot started work on behalf of fregante January 10, 2026 15:49 View session

Copilot AI requested a review from fregante January 10, 2026 15:53

Copilot finished work on behalf of fregante January 10, 2026 15:53

Copilot started work on behalf of fregante January 10, 2026 17:21 View session

fregante marked this pull request as ready for review January 10, 2026 17:21

fregante changed the title ~~Meta: Fail loudly~~ Meta: Avoid failing silently for DOM searches Jan 10, 2026

fregante added the meta Related to Refined GitHub itself label Jan 10, 2026

fregante changed the title ~~Meta: Avoid failing silently for DOM searches~~ Avoid failing silently for DOM searches Jan 10, 2026

Copilot AI changed the title ~~Avoid failing silently for DOM searches~~ Meta: Fail loudly Jan 10, 2026

Copilot finished work on behalf of fregante January 10, 2026 17:24

pita

6521c8d

fregante changed the title ~~Meta: Fail loudly~~ Meta: Avoid failing silently for DOM searches Jan 10, 2026

fregante added 7 commits January 11, 2026 22:00

Discard changes to source/features/clear-pr-merge-commit-message.tsx

2488a64

Update dim-bots.tsx

fc41408

Discard changes to source/features/hidden-review-comments-indicator.tsx

56f7acc

Update highest-rated-comment.tsx

c363e32

Discard changes to source/features/open-issue-to-latest-comment.tsx

d9e2636

Update quick-comment-hiding.tsx

ac6d059

Update release-download-count.tsx

75e129c

fregante mentioned this pull request Jan 26, 2026

update-pr-from-base-branch: Error updating the branch: expected head sha didn’t match current head ref. #8905

Open

1 task

fregante added 2 commits January 26, 2026 16:47

Restore countElements

d2e0768

Change import and usage of $$ to $$optional

45a508c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Meta: Avoid failing silently for DOM searches #8863

Meta: Avoid failing silently for DOM searches #8863

Copilot AI commented Jan 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fregante commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Uh oh!

Meta: Avoid failing silently for DOM searches #8863

Are you sure you want to change the base?

Meta: Avoid failing silently for DOM searches #8863

Conversation

Copilot AI commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Example

Test URLs

Screenshot

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fregante commented Jan 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 10, 2026 •

edited

Loading