Only show the import notification for the first time - #2065
Merged
testforstephen merged 1 commit intoAug 17, 2021
Conversation
Signed-off-by: Sheng Chen <sheche@microsoft.com>
testforstephen
approved these changes
Aug 17, 2021
testforstephen
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Since this commit is related with other importing enhancements in 0.81.0, i prefer to carry it in the upcoming 0.81.0 release. @rgrunber what do you think?
Member
|
Sounds good. I'm assuming we need not update the changelogs as the relevant issues are mentioned. |
Collaborator
yes, no need to update changelog. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since our message is called
Projects are imported into workspace.So it should only be shown for the first time.To know whether the projects have been imported or not, I check the existence of
.metadata/.plugins, which is used before: https://github.com/redhat-developer/vscode-java/blob/master/src/extension.ts#L334Signed-off-by: Sheng Chen sheche@microsoft.com
@rgrunber Sorry for the late patch. Please consider if this should be contained in 0.81.0