Added size hinting implementation in UIGridLayout#1478
Added size hinting implementation in UIGridLayout#1478eruvanos merged 4 commits intopythonarcade:gui/grid_layoutfrom
Conversation
|
Actually, the implementation is not what I expected, but I will check, if I was missing some tests. I thought more into the direction, that the do_layout follows the behaviour from: https://github.com/pythonarcade/arcade/blob/development/doc/programming_guide/gui/concept.rst#uiwidget UIWidget:
size_hint, size_hint_min, and size_hint_max are values that are additional information of a widget, but do not effect the widget on its own. :class:
The |
Ah, I will add a check if the widget's size hints are not None before resizing them. Other than that I think it is following the arcade gui concept right? |
New changes in the code for size hinting is according to this text. |
|
Great work, thank you! |
* added resizing in UIGridLayout * resizing child widgets iff they have non None size hints * Implemented actual size hinting in UIGridLayout * Edited tests for size hinting
* UI: add tests for UIGridLayout to change size of children * UI: improve layout documentation * UI: Added size hinting implementation in UIGridLayout (#1478) Co-authored-by: Mohammad Ibrahim <74553450+Ibrahim2750mi@users.noreply.github.com>
#1101