Created UIButtonRow.#1253
Closed
JackAshwell11 wants to merge 4 commits intopythonarcade:developmentfrom
JackAshwell11:uibuttonrow
Closed
Created UIButtonRow.#1253JackAshwell11 wants to merge 4 commits intopythonarcade:developmentfrom JackAshwell11:uibuttonrow
JackAshwell11 wants to merge 4 commits intopythonarcade:developmentfrom
JackAshwell11:uibuttonrow
Conversation
Contributor
Author
|
Resolves #1248 |
Member
|
Hi, We talked through a few changes, would you like to update your PR or should we just merge it and then update the class? |
pushfoo
approved these changes
Jun 26, 2022
Member
pushfoo
left a comment
There was a problem hiding this comment.
It looks good to me, although my understanding of the event system is still limited.
Member
|
I rebased the commits and added a PR #1580 with the commit under your name @Aspect1103 . Thank you for the contribution and sorry for the long delay until this was cleared. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.