ENH: Patch versioneer files into manifest at runtime#309
Merged
effigies merged 2 commits intopython-versioneer:masterfrom Aug 9, 2022
Merged
ENH: Patch versioneer files into manifest at runtime#309effigies merged 2 commits intopython-versioneer:masterfrom
effigies merged 2 commits intopython-versioneer:masterfrom
Conversation
Hack egg_info to modify SOURCES.txt, adding versioneer.py and versionfile_source. versionfile_source is necessary in cases where there's a single module.py file in the root. Admittedly a boutique case, but one we test for.
bae3128 to
b44f75d
Compare
Contributor
Author
|
Thinking about this again, I think using the I would appreciate a review, if anybody has the time and interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hack egg_info to modify SOURCES.txt, adding versioneer.py and versionfile_source. versionfile_source is necessary in cases where there's a single module.py file in the root. Admittedly a boutique case, but one we test for.
This removes the need to add these files to
MANIFEST.in, which has been a source of annoyance (#40, #247, probably others...).Closes #40.
Addresses part of #247.