FIX: old GIT (<1.7.2) does not know about --count flag#306
Merged
effigies merged 4 commits intopython-versioneer:masterfrom Jul 21, 2022
foxtran:fix/old-git
Merged
FIX: old GIT (<1.7.2) does not know about --count flag#306effigies merged 4 commits intopython-versioneer:masterfrom foxtran:fix/old-git
--count flag#306effigies merged 4 commits intopython-versioneer:masterfrom
foxtran:fix/old-git
Conversation
effigies
reviewed
Jul 21, 2022
effigies
reviewed
Jul 21, 2022
effigies
reviewed
Jul 21, 2022
Contributor
effigies
left a comment
There was a problem hiding this comment.
Our mock runner needs to be updated now:
python-versioneer/test/git/test_git.py
Lines 42 to 43 in 280fb6c
I would suggest something like:
if args[0] == "rev-list":
- return "42\n", 0
+ return "hash\n" * 42, 0Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Contributor
|
Thanks! |
Contributor
Author
|
Thank you :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98, fixes #187.
--countflag comes from git v1.7.2 with commit git/git@f69c501Note: I tried this PR on already-generated
versioneer.py, I did not test that its generation is correct.