Undefined name: VersioneerBadRootError on line 51 by cclauss · Pull Request #305 · python-versioneer/python-versioneer

cclauss · 2022-07-14T14:09:50Z

VersioneerBadRootError is used on line 51 but it is never imported which may result in a NameError being raised instead.

`VersioneerBadRootError` is used on line 51 but it is never imported which may result in a NameError being raised instead.

effigies

The way versioneer is set up is actually to concatenate these files into a single file that can be vendored:

python-versioneer/setup.py

Lines 51 to 74 in 280fb6c

    
           def generate_versioneer_py(): 
        
               s = io.StringIO() 
        
               s.write(get("src/header.py", add_ver=True, do_readme=True)) 
        
               s.write(get("src/subprocess_helper.py", do_strip=True)) 
        
               for VCS in get_vcs_list(): 
        
                   s.write(f"LONG_VERSION_PY['{VCS}'] = r'''\n") 
        
                   s.write(generate_long_version_py(VCS)) 
        
                   s.write("'''\n") 
        
                   s.write("\n\n") 
        
                   s.write(get(f"src/{VCS}/from_keywords.py", do_strip=True)) 
        
                   s.write(get(f"src/{VCS}/from_vcs.py", do_strip=True)) 
        
                   s.write(get(f"src/{VCS}/install.py", do_strip=True)) 
        
               s.write(get("src/from_parentdir.py", do_strip=True)) 
        
               s.write(get("src/from_file.py", add_ver=True, do_strip=True)) 
        
               s.write(get("src/render.py", do_strip=True)) 
        
               s.write(get("src/get_versions.py", do_strip=True)) 
        
               s.write(get("src/cmdclass.py", do_strip=True)) 
        
               s.write(get("src/setupfunc.py", do_strip=True)) 
        
               return s.getvalue().encode("utf-8")

To avoid multiple imports and definitions, it uses stubs that are then stripped during the build.

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

Undefined name: VersioneerBadRootError on line 51

ceb878a

`VersioneerBadRootError` is used on line 51 but it is never imported which may result in a NameError being raised instead.

effigies reviewed Jul 14, 2022

View reviewed changes

Comment thread src/header.py Outdated

cclauss and others added 2 commits July 14, 2022 17:11

Update src/header.py

58cc50c

Co-authored-by: Chris Markiewicz <effigies@gmail.com>

FIX: strip header.py as well

8a5657a

effigies merged commit 2123b15 into python-versioneer:master Jul 27, 2022

cclauss deleted the patch-1 branch July 27, 2022 02:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Undefined name: VersioneerBadRootError on line 51#305

Undefined name: VersioneerBadRootError on line 51#305
effigies merged 3 commits intopython-versioneer:masterfrom
cclauss:patch-1

cclauss commented Jul 14, 2022

Uh oh!

effigies left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	def generate_versioneer_py():
	s = io.StringIO()
	s.write(get("src/header.py", add_ver=True, do_readme=True))
	s.write(get("src/subprocess_helper.py", do_strip=True))

	for VCS in get_vcs_list():
	s.write(f"LONG_VERSION_PY['{VCS}'] = r'''\n")
	s.write(generate_long_version_py(VCS))
	s.write("'''\n")
	s.write("\n\n")

	s.write(get(f"src/{VCS}/from_keywords.py", do_strip=True))
	s.write(get(f"src/{VCS}/from_vcs.py", do_strip=True))

	s.write(get(f"src/{VCS}/install.py", do_strip=True))

	s.write(get("src/from_parentdir.py", do_strip=True))
	s.write(get("src/from_file.py", add_ver=True, do_strip=True))
	s.write(get("src/render.py", do_strip=True))
	s.write(get("src/get_versions.py", do_strip=True))
	s.write(get("src/cmdclass.py", do_strip=True))
	s.write(get("src/setupfunc.py", do_strip=True))

	return s.getvalue().encode("utf-8")

Conversation

cclauss commented Jul 14, 2022

Uh oh!

effigies left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants