FIX: Improved handling of refname edge cases#229
Merged
effigies merged 2 commits intopython-versioneer:masterfrom Dec 6, 2020
Merged
FIX: Improved handling of refname edge cases#229effigies merged 2 commits intopython-versioneer:masterfrom
effigies merged 2 commits intopython-versioneer:masterfrom
Conversation
This is an edge case that can be hit if using git-archive on a release with no refnames.
Contributor
Author
|
Anybody care to review? |
Contributor
Author
|
This does resolve concrete issues for me, and hasn't spawned outrage. I'll go ahead and merge... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers two edge cases.
The first is a case where the
keywordspassed togit_versions_from_keywords()is non-empty butrefnamesis missing. IIRC this could occur ingit archives for hashes that had no branches or tags associated. This breaks L54:python-versioneer/src/git/from_keywords.py
Line 54 in 8071eaa
Instead we reduce the check to
'refnames' in keywords, which covers the actually erroring case, and provide a better error message.The second is a case where you might have a tag
test_tag. If you have a tag prefix'v', this will get filtered out. If your tag prefix is'', then all weird tags get pulled in. So I've added a filter that requires the first character of the tag (post-prefix) to be a digit.