Skip to content

Added async bleech code#1

Merged
pquentin merged 5 commits intomasterfrom
patch-1
Oct 27, 2018
Merged

Added async bleech code#1
pquentin merged 5 commits intomasterfrom
patch-1

Conversation

@RatanShreshtha
Copy link
Copy Markdown
Member

@RatanShreshtha RatanShreshtha commented Oct 25, 2018

No description provided.

@pquentin
Copy link
Copy Markdown
Member

pquentin commented Oct 25, 2018 •
edited
Loading

Okay, let's see if we can make Travis happy.

Can you start with this as mentioned in the CHECK_FORMATTING build?

pip install yapf==0.22.0
yapf -rpi setup.py asyncbleach

You forgot a few imports, too.

(By the way, it's bleach, not bleech. Bleach removes color, in our case async color).

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 26, 2018 •
edited
Loading

Codecov Report

Merging #1 into master will decrease coverage by 70%.
The diff coverage is 19.35%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #1    +/-   ##
=====================================
- Coverage     100%   30%   -70%     
=====================================
  Files           4     4            
  Lines          12    80    +68     
  Branches        1    16    +15     
=====================================
+ Hits           12    24    +12     
- Misses          0    56    +56
Impacted Files Coverage Δ
asyncbleach/_tests/test_example.py 100% <ø> (ø) ⬆️
asyncbleach/__init__.py 18.84% <19.35%> (-81.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faaac22...eb9aa76. Read the comment docs.

pquentin
pquentin reviewed Oct 27, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the re and codecs imports? They're not needed here.

pquentin
pquentin approved these changes Oct 27, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can't merge myself, can you do it with a squash commit? Or give me access to your repository

@pquentin pquentin merged commit d3137c9 into master Oct 27, 2018
@pquentin pquentin deleted the patch-1 branch October 27, 2018 06:11
@pquentin
Copy link
Copy Markdown
Member

pquentin commented Oct 27, 2018

✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pquentin pquentin pquentin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RatanShreshtha @pquentin @codecov-io