only save token to disk if reuse session is true - #81
Merged
tchellomello merged 2 commits intoMay 16, 2018
Conversation
…ment so when we are not reusing the session it does not attempt to persist the token to disk.
houndci-bot
reviewed
Jan 9, 2018
| if self._reuse_session: | ||
| self.cache['account'] = self.username | ||
| self.cache['token'] = self.token | ||
| _save_cache(self.cache, self.cache_file) |
There was a problem hiding this comment.
IndentationError: unindent does not match any outer indentation level
Contributor
Author
|
does this have any relation to this pylint issue? Works in my 3.5 environment as expected. |
Member
|
Thanks for your contribution @andrewkress. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move the _save_cache(self.cache, self.cache_file) inside the if statement
so when we are not reusing the session it does not attempt to persist the
token to disk. This resolves issue #79