Skip to content

Created generic update method for all devices on Ring top-parent object #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchellomello merged 1 commit into from
Nov 29, 2017
Merged

Created generic update method for all devices on Ring top-parent object #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ring_doorbell/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,3 +253,12 @@ def stickup_cams(self):
def doorbells(self):
"""Return a list of RingDoorBell objects."""
return self.__devices('doorbells')

def update(self):
"""Refreshes attributes for all linked devices."""
for device_lst in self.devices.values():
for device in device_lst:
if hasattr(device, "update"):
_LOGGER.debug("Updating attributes from %s", device.name)
getattr(device, "update")
return True
2 changes: 2 additions & 0 deletions tests/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ def setUp(self, mock):
self.ring_persistent = \
Ring(USERNAME, PASSWORD, cache_file=CACHE, persist_token=True)

self.assertTrue(hasattr(self.ring, "update"))

def cleanup(self):
"""Cleanup any data created from the tests."""
self.ring = None
Expand Down