Implemented health parameters reporting (wifi, wifi_rssi) - #50
Merged
Conversation
tchellomello
force-pushed
the
rssi_support
branch
from
September 30, 2017 05:29
609d01f to
32c4d88
Compare
tchellomello
force-pushed
the
rssi_support
branch
from
September 30, 2017 08:14
32c4d88 to
9c3472c
Compare
1 similar comment
Contributor
|
thanks for pushing this out so quickly! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[x] - Coverage Doorboots
[x] - Coverage Door Chimes
[x] - Coverage Stickup Cams
[x] - Fix & Add unit tests
Fixes: #47
This PR introduces a support to report some health attributes such as wifi_name, wifi_signal_strength and wifi_signal_category.
Currently, it is only valid for doorbots but we need to extend this to door chimes too.
Many thanks to @zzsmith and @keeth