Skip to content

Allows to filter history by event kind: 'motion', 'on_demand', 'ding' #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchellomello merged 2 commits into from
Mar 10, 2017
+5 −1
Merged

Allows to filter history by event kind: 'motion', 'on_demand', 'ding' #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bee1b2
Allows to filter history by event kind: 'motion', 'on_demand', 'ding'
tchellomello Mar 10, 2017
dff2064
Fixed whitespace
tchellomello Mar 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ring_doorbell/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ def existing_doorbell_type_duration(self, value):
return True
return None

def history(self, limit=30, timezone=None):
def history(self, limit=30, timezone=None, kind=None):
"""Return history with datetime objects."""
# allow modify the items to return
params = {'limit': str(limit)}
Expand All @@ -508,6 +508,10 @@ def history(self, limit=30, timezone=None):
entry['created_at'] = tz_dt
else:
entry['created_at'] = utc_dt

if kind:
return list(filter(lambda array: array['kind'] == kind, response))

return response

@property
Expand Down