Introduced check_alerts() method - #17
Merged
Merged
Conversation
…llow concurrent objects to share alert notifications
tchellomello
added a commit
that referenced
this pull request
Mar 9, 2017
* Moved subscribed and subscribed_motion attributes to doorbell devices only * Allows option to make token persistent and register push_notify_urls * Introduced check_alerts() method (#17) * added initial control to alert notifications * Removed JSON from tests * Make lint happy * Update README * Only publish PUSH url if we have one * Display error message only if in debug * override default URL * Make check alerts a callable function * Removed extra space * Move inside the try/except for safeness * Introduced mecanism to save current alert state to a pickle file to allow concurrent objects to share alert notifications * Moved self._alert_cache position * version bump 0.1.1
tchellomello
added a commit
that referenced
this pull request
Mar 13, 2017
* Moved subscribed and subscribed_motion attributes to doorbell devices only * Allows option to make token persistent and register push_notify_urls * Introduced check_alerts() method (#17) * added initial control to alert notifications * Removed JSON from tests * Make lint happy * Update README * Only publish PUSH url if we have one * Display error message only if in debug * override default URL * Make check alerts a callable function * Removed extra space * Move inside the try/except for safeness * Introduced mecanism to save current alert state to a pickle file to allow concurrent objects to share alert notifications * Moved self._alert_cache position * version bump 0.1.1 * Allows to filter history by event kind: 'motion', 'on_demand', 'ding' (#20) * Allows to filter history by event kind: 'motion', 'on_demand', 'ding' * Fixed whitespace * Unittests (#22) * Introduced base skeleton for unittest * Added thanks to the http://www.android-x86.org/ community * Added basic structure for docs (#24) * Added basic structure for docs * fixed lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via this method, we will have an attribute to store the response received from the notification request and to save the timestamp for how much time the request is 'on-going' or 'valid'.
This will be useful in cases where a ring happened but we want to keep the notification active for the next 180 seconds (which is the default).