Refactored project to make it more Pythonish and transparent - #14
Merged
Conversation
Update Readmine due to refactor
houndci-bot
reviewed
Feb 24, 2017
| def test_sound(self): | ||
| """Play chime to test sound.""" | ||
| url = API_URI + TESTSOUND_CHIME_ENDPOINT.format(self.account_id) | ||
| response = self._ring.query(url, method='POST') |
There was a problem hiding this comment.
local variable 'response' is assigned to but never used
|
Seems to work fine except for However, odd thing: If I press |
Member
Author
|
@syphernl could you please test it again? And my dogs also love this feature :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAK CHANGES (not ready to commit yet)
This PR is basically a rewrite from the project which nows allows to treat the devices as objects and not as functions anymore. This change will introduce more transparency to the user.
Fixes issue #13