Support for device model name property and has capability method - #116
Merged
Conversation
Collaborator
Author
|
I made the change as agreed. In the process, I swapped the wired property implementation for a capability check method, which is more in line with the capabilities matrix I compiled in my original issue. The following capabilities can be determined for each device:
On a side note, I removed the battery_life method from the chime class since that device is always hardwired. |
Collaborator
Author
|
@tchellomello are you fine with the changes I made? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to get a given device model name and determine its capabilities.
Fixes: #112
Fixes: #114