Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #604 +/- ##
=======================================
Coverage 84.91% 84.91%
=======================================
Files 38 38
Lines 3381 3381
Branches 851 851
=======================================
Hits 2871 2871
Misses 424 424
Partials 86 86 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Yeah, that is failing as the device is not connected to the cloud: I'm wondering if I should leave it as-is or allow my devices temporarily to access the cloud for this. Looks like the final query is now also failing (with timeout) although it worked pre-merge just fine.. Raising the timeout to 10s doesn't seem to help :-) |
Collaborator
|
Ah ok. That’s fine. I think keep it as-is for now as it gives us an aes device and a slightly different use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated fixture using dump_devinfo from #597