Add optional error code to exceptions#585
Merged
rytilahti merged 1 commit intopython-kasa:masterfrom Dec 20, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #585 +/- ##
==========================================
+ Coverage 84.78% 84.82% +0.04%
==========================================
Files 37 37
Lines 3220 3230 +10
Branches 810 810
==========================================
+ Hits 2730 2740 +10
Misses 413 413
Partials 77 77 ☔ View full report in Codecov by Sentry. |
rytilahti
approved these changes
Dec 20, 2023
Member
rytilahti
left a comment
There was a problem hiding this comment.
Looks straightforward to me. We will want to document this and other new changes in the docs, but that can wait for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken out from #584