Improve smartprotocol error handling and retries#578
Merged
rytilahti merged 3 commits intopython-kasa:masterfrom Dec 10, 2023
Merged
Improve smartprotocol error handling and retries#578rytilahti merged 3 commits intopython-kasa:masterfrom
rytilahti merged 3 commits intopython-kasa:masterfrom
Conversation
273d8a2 to
1a57e63
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #578 +/- ##
==========================================
- Coverage 79.59% 79.26% -0.34%
==========================================
Files 37 37
Lines 3088 3178 +90
Branches 806 818 +12
==========================================
+ Hits 2458 2519 +61
- Misses 547 574 +27
- Partials 83 85 +2 ☔ View full report in Codecov by Sentry. |
rytilahti
reviewed
Dec 8, 2023
Member
rytilahti
left a comment
There was a problem hiding this comment.
Looking good! 👍 Just some brief feedback off the bat, I'll check out this in more detail later.
rytilahti
reviewed
Dec 8, 2023
rytilahti
reviewed
Dec 8, 2023
rytilahti
reviewed
Dec 8, 2023
Collaborator
Author
|
Most of the comments addressed. I think the one you may come back on from the open conversations is the |
rytilahti
approved these changes
Dec 9, 2023
Member
rytilahti
left a comment
There was a problem hiding this comment.
Looking really good, just a couple of very minor nits that may be worth considering.
ea2d9fd to
e4b7b76
Compare
Collaborator
Author
|
All addressed and rebased to master so hopefully ready to go |
rytilahti
approved these changes
Dec 10, 2023
Member
rytilahti
left a comment
There was a problem hiding this comment.
Let's get it merged then, thanks! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the SMART error codes and has handling to interpret them and avoid retries for authentication errors.
I haven't been able to test it with an actual AES device but it works with TAPO/KLAP.
I've rebased #569 on top of this PR to help with testing.