Merged
Conversation
bdraco
added a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Apr 13, 2022
It worked out of box with no changes python-kasa/python-kasa#339
8 tasks
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
=======================================
Coverage 80.52% 80.52%
=======================================
Files 25 25
Lines 1715 1715
Branches 237 237
=======================================
Hits 1381 1381
Misses 300 300
Partials 34 34 Continue to review full report at Codecov.
|
rytilahti
approved these changes
Apr 13, 2022
Member
rytilahti
left a comment
There was a problem hiding this comment.
Thanks! Mind updating the README, too?
rytilahti
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Apr 13, 2022
It worked out of box with no changes python-kasa/python-kasa#339
Member
Author
👍 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one worked out of box